Expand libraries vignette with PACKAGE_types.h#1355
Merged
eddelbuettel merged 2 commits intomasterfrom Jan 26, 2025
Merged
Conversation
eddelbuettel
force-pushed
the
feature/expand_vignette
branch
from
4e2afc5 to
d082a65
Compare
Enchufa2
approved these changes
Jan 26, 2025
Member
Enchufa2
left a comment
Enchufa2
left a comment
There was a problem hiding this comment.
Typo below; otherwise, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from a discussion over at RcppEigen which revealed that our trick of using
PACKAGE_types.hto declare types known toRcppExports.cppis not as well known.So a brief reference was added to Rcpp-libraries vignette which is somewhat topical.
Checklist
R CMD checkstill passes all tests